-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Helpsite consolidateV2 #81045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@rlinoz @greg-schroeder One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| @@ -0,0 +1,5 @@ | |||
| — | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML frontmatter syntax error: The YAML frontmatter delimiters should use three hyphens --- (not em dashes —).
This will prevent the YAML metadata from being parsed correctly. Change to:
---
title: Manage Your Billing
---| @@ -0,0 +1,5 @@ | |||
| — | |||
| title: Manage Your Billing | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing YAML metadata (AI Readiness violation): The frontmatter is missing required fields for AI readiness:
description: A concise, benefit-focused summarykeywords: Feature name, related terms, navigation path, etc.
Example:
---
title: Manage Your Billing
description: Learn how to view and manage your Expensify billing and subscription details.
keywords: [billing, subscription, payment, invoice, manage billing, billing settings]
---| title: Manage Your Billing | ||
| — | ||
|
|
||
| Article body here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder content (Readability violation): The article contains only placeholder text "Article body here." This provides no useful information to users.
Please add complete, informative content that:
- Uses clear, scannable headings
- Provides step-by-step instructions where applicable
- Uses 8th grade reading level or below
- Includes a breadcrumb path below the H1 heading
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new consolidated platform section to the HelpDot documentation structure, but the implementation is incomplete and contains several critical issues that must be addressed before merging. Scores Summary
Key Findings - Critical Issues
Recommendations Priority 1 - Blocking
Files Reviewed
Final RecommendationDo not merge until Priority 1 blocking issues resolved. This would break builds and provide no user value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86c7ce2825
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| — | ||
| title: Manage Your Billing | ||
| — |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use valid YAML front matter delimiters
The page front matter uses Unicode em dashes (—) instead of the required --- delimiters, so Jekyll will not treat this as a Markdown page with metadata. In that case the file is copied as a static asset and the title is ignored, which means the article won’t render through the site layout and will show the raw front matter line. This will happen whenever the docs site is built by Jekyll.
Useful? React with 👍 / 👎.
…ocs/articles/consolidated/billing/Subscription and Plan Management/How-billing-ownership-and-subscription-management-work-in-Expensify.md
…iptions-in-Expensify.md
… How-to-Manage-Subscriptions-and-Billing-in-New-Expensify.md
…s-in-Expensify.md
Codecov Report✅ All modified and coverable lines are covered by tests. |
…wnership-means-in-expensify.md
…pdate corresponding HTML file
…reflect the changes
…yml and create corresponding markdown files
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari