Skip to content

Conversation

@stephanieelliott
Copy link
Contributor

@stephanieelliott stephanieelliott commented Jan 30, 2026

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot
Copy link

melvin-bot bot commented Jan 30, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot melvin-bot bot requested review from greg-schroeder and rlinoz and removed request for a team January 30, 2026 18:22
@melvin-bot
Copy link

melvin-bot bot commented Jan 30, 2026

@rlinoz @greg-schroeder One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@@ -0,0 +1,5 @@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML frontmatter syntax error: The YAML frontmatter delimiters should use three hyphens --- (not em dashes ).

This will prevent the YAML metadata from being parsed correctly. Change to:

---
title: Manage Your Billing
---

@@ -0,0 +1,5 @@
title: Manage Your Billing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing YAML metadata (AI Readiness violation): The frontmatter is missing required fields for AI readiness:

  • description: A concise, benefit-focused summary
  • keywords: Feature name, related terms, navigation path, etc.

Example:

---
title: Manage Your Billing
description: Learn how to view and manage your Expensify billing and subscription details.
keywords: [billing, subscription, payment, invoice, manage billing, billing settings]
---

title: Manage Your Billing

Article body here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder content (Readability violation): The article contains only placeholder text "Article body here." This provides no useful information to users.

Please add complete, informative content that:

  • Uses clear, scannable headings
  • Provides step-by-step instructions where applicable
  • Uses 8th grade reading level or below
  • Includes a breadcrumb path below the H1 heading

@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a new consolidated platform section to the HelpDot documentation structure, but the implementation is incomplete and contains several critical issues that must be addressed before merging.

Scores Summary

  • Readability: 1/10 - Placeholder text only with YAML syntax error
  • AI Readiness: 2/10 - No metadata, broken YAML formatting
  • Style Compliance: 1/10 - Multiple violations including YAML syntax, missing metadata, placeholder content

Key Findings - Critical Issues

  1. Broken YAML: Uses em-dash instead of triple-dash delimiters
  2. Placeholder Content: Only Article body here - no actual documentation
  3. Missing Metadata: No description, keywords, or internalScope
  4. Wrong URL: Uses travel.expensify.com instead of proper consolidated domain
  5. Capitalization Issues: Lowercase titles throughout routing config

Recommendations Priority 1 - Blocking

  • Fix YAML syntax error
  • Add complete article content
  • Add required frontmatter fields
  • Fix routing configuration URL and capitalization
  • Clarify what consolidated platform represents

Files Reviewed

  • docs/_data/_routes.yml: Structural issues with URL, capitalization
  • docs/articles/consolidated/billing/manage-your-billing.md: Critical YAML error, no content
  • docs/consolidated/hubs/billing/index.html: Title inconsistencies
  • docs/consolidated/hubs/index.html: Template title mismatch

Final Recommendation

Do not merge until Priority 1 blocking issues resolved. This would break builds and provide no user value.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86c7ce2825

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 1 to 3
title: Manage Your Billing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use valid YAML front matter delimiters

The page front matter uses Unicode em dashes () instead of the required --- delimiters, so Jekyll will not treat this as a Markdown page with metadata. In that case the file is copied as a static asset and the title is ignored, which means the article won’t render through the site layout and will show the raw front matter line. This will happen whenever the docs site is built by Jekyll.

Useful? React with 👍 / 👎.

@github-actions github-actions bot changed the title Helpsite consolidayev2 [No QA] Helpsite consolidayev2 Jan 30, 2026
@stephanieelliott stephanieelliott changed the title [No QA] Helpsite consolidayev2 [No QA] Helpsite consolidateV2 Jan 30, 2026
…ocs/articles/consolidated/billing/Subscription and Plan Management/How-billing-ownership-and-subscription-management-work-in-Expensify.md
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 106 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants